search

robincsamuel / laravel-msg91

Package for MSG91 sms API
MIT License
8 stars 12 forks source link

Laravel Upgrade 8.0 #18

Closed hironate closed 3 years ago

hironate commented 3 years ago

Laravel 8 uses Guzzle version 7.0.1, we need to upgrade version to support this package on laravel version 8.

robincsamuel commented 3 years ago

Thanks, @Hironate. I'll find some time to try this out. I think this won't be backward compatible, so probably, we'll have to bump a major version.

hironate commented 3 years ago

@robincsamuel are you planning for new release supporting laravel 8 ?

robincsamuel commented 3 years ago

@Hironate Sorry, I couldn't find time to try this out. Here is my thought, since guzzle is upgraded to version 7, it needs PHP 7, which is a breaking change. That'd make the package backward-incompatible, and therefore, I thought we should verify this and put a note about the same before merging.