robincsamuel / laravel-msg91

Package for MSG91 sms API
MIT License
8 stars 12 forks source link

DLT Template #22

Closed smarteertech closed 3 years ago

smarteertech commented 3 years ago

Please add one more URL params called DLT_TE_ID to pass on to the API. It is mandatory now.

robincsamuel commented 3 years ago

@smarteertech Can you elaborate a bit more? Is it when you sending an sms or for the sendOtp function?

smarteertech commented 3 years ago

Someone already added it seems, you can refer this forked version for the exact change. https://github.com/Hironate/laravel-msg91/commit/06e87ee2b233adfb02d9f009280bb1a753626374

robincsamuel commented 3 years ago

I see that, but I'm not sure that'll solve all the cases. For example, there is a sendOtp function, the above-mentioned change is only for the message function. I'm trying to find more about this param and maybe implement that to work for all the cases and also include examples.

smarteertech commented 3 years ago

Sure, for now, we added this params and used for our message, it works good. I am not sure about OTP.

robincsamuel commented 3 years ago

Can you show me an example working request? I can cross-check and merge that PR.

smarteertech commented 3 years ago

We are sending DLT template like this $sms = LaravelMsg91::message($journey->customer_phone, $message, array('DLT_TE_ID' => '1234567890123546798'));

robincsamuel commented 3 years ago

Thanks for sharing the details, I'm merging the PR.