Several new functions added

robindijkhof / overleaf-textarea

This plugin displays your tex source in a textarea so plugins like grammarly can check it.

GNU General Public License v3.0

514 stars 31 forks source link

Several new functions added #49

Closed Jpfonseca closed 3 years ago

Jpfonseca commented 3 years ago

Added several functions and corrected \caption so the ending } gets captured if there's a \function{} inside it

Jpfonseca commented 3 years ago

This is contribution is based on #34 by @phschaer.

robindijkhof commented 3 years ago

Closing this as I manually added your changes and added some tests.

Jpfonseca commented 3 years ago

May I ask why not just add the contributions from other contributors directly from the Pull request ? I am asking it as it is a good practice in Opensource projects to keep the list of contributors and contributions... By avoiding to do that you are sorta grabbing the work from others and saying it's yours...

I don't want to start any sort of fight over this.

Anyway thanks for the project:raised_hands:

robindijkhof commented 3 years ago

Some reasons:

There were merge conflicts
I added tests based on your work
I did not include all of your changes

I know these issues could be solved with some merge requests back and forth, but I don't really have the time to respond directly. That is probably why this MR is open for more than two weeks. I figured you and possibly others were waiting for these changes, so I quickly added your changes. I'll see if I can do this better next time.