search

robindijkhof / overleaf-textarea

This plugin displays your tex source in a textarea so plugins like grammarly can check it.
GNU General Public License v3.0
513 stars 31 forks source link

Wrong replacement for cite #70

Closed gege-hoho closed 2 years ago

gege-hoho commented 2 years ago

There seems to be an issue with cite: Little et. al. \cite{little} distinguishes between three different mechanisms that lead to missing data \cite{little}. Results in Little et. al.. When I remove the trailing dot, the text is displayed correctly: Little et. al. distinguishes between three different mechanisms that lead to missing data

Jpfonseca commented 2 years ago

I haven't looked into it but I believe it's caused by this line https://github.com/robindijkhof/overleaf-textarea/blob/7e1b59b32cecbba499bf4975b6ca66f103bd0321/source/filter-helper.ts#L22

robindijkhof commented 2 years ago

I cannot reproduce it. I might have fixed this before, but not released it. Can you try it again tomorrow after tonight's release?

Jpfonseca commented 2 years ago

The behaviour doesn't always happen from my tests. There are two repeted expressions.

Jpfonseca commented 2 years ago

@robindijkhof please merge #73

gege-hoho commented 2 years ago

In version 2.0.5 it works flawlessly! Thank you @robindijkhof @Jpfonseca