robindijkhof / overleaf-textarea

This plugin displays your tex source in a textarea so plugins like grammarly can check it.
GNU General Public License v3.0
514 stars 31 forks source link

The Chrome extension does not work with blank in the textarea #84

Closed kelvinzz closed 1 year ago

kelvinzz commented 1 year ago

I disabled all the extensions on Chrome except Grammarly and Overleaf textarea. However, the textarea is blank (see the picture below). Any suggestion would be helpful. Thanks.

image

AllanChain commented 1 year ago

Overleaf is removing the legacy editor and this extension seems incompatible with the new editor. Looking forward to a fix.

robindijkhof commented 1 year ago

Is that really necessary? I though the new editor supported grammarly?

AllanChain commented 1 year ago

Is that really necessary? I thought the new editor supported grammarly?

The new editor does support Grammarly, but this extension still offers some features the new editor doesn't provide. For example, the filter feature is really useful to produce a cleaner document for Grammarly and reduce false positives.

It's not so necessary, but I'll prefer to use this extension if it supports the new editor.

robindijkhof commented 1 year ago

I am not really using overleaf anymore, but I'll see what I can do.

EDIT: so far it seems doable en not too hard. Might have an update in a few days.

robindijkhof commented 1 year ago

new version is published

robindijkhof commented 1 year ago

@AllanChain, can you confirm it works?

AllanChain commented 1 year ago

I gave it a test with Firefox. The textarea shows the document correctly, but when I try to fix the grammar, it also replaces the previous line. Something like:

-Some content
-You can use emoji-modifiers:
+You can use emoji modifiers:
+You can use emoji modifiers:

And the custom filter is having an infinite loop and keeps polluting the content. Something like:

/\\emoji\{(.*?)\}/ -> $1
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}\begin{document}
\emoji{rose}
\emoji{rose}
\emoji{rose}
\emoji{rose}

Finally, the scroll sync is not working correctly.


Seems that the new Overleaf editor is very different from the old one and supporting the new editor takes more effort than I thought... Maybe it's better to just use Grammarly checking in the new editor...

robindijkhof commented 1 year ago

@AllanChain that's not something I can reproduce. Everything looks fine. Any chance you can create a reproducible example?

AllanChain commented 1 year ago

I tried again today and can't reproduce it either. I don't know what's wrong.