search

robinglen / lighthouse-cron

Tool to run light house cron jobs on multiple urls and ship results
MIT License
44 stars 3 forks source link

Changes this.flags to this.chromeFlags #3

Closed tcelestino closed 6 years ago

tcelestino commented 6 years ago

I've been trying use the chromeFlags with options in the class LighthouseCron but it does not work. Looking the code I've seen that you created the property this.chromeFlags in the constructor class but you don't use, you're using the property this.flags instead.

:package: I removed a variable Printer if you don't use too.

If you approve this PR, could you do publish on npm repository? :crab:

robinglen commented 6 years ago

Hey @tcelestino I'm just working away today, let me look this over and then get it merged and published ASAP.

tcelestino commented 6 years ago

@thearegee no problem. :open_hands:

robinglen commented 6 years ago

@tcelestino done, merged published