search

robinhood-suite / robinhood4

This repository holds the source code for robinhood version 4, a suite of tools to store and query any filesystem's metadata.
6 stars 3 forks source link

Bugfix #1

Closed Amin000 closed 9 months ago

Amin000 commented 11 months ago

Fix some bugs.

  1. Add support for /xxx
  2. Fix id_node_alloc without removing.
courrierg commented 9 months ago

Hello @Amin000,

Thank you for the bug fixes. Both commits look fine, we will just do a few tests. One nitpick: the commit messages should be a bit more descriptive. We usually follow this template:

tool name: brief description

relevant information to explain what was the bug is (what command fails and how) and how it was solved.

If you could update the commit messages, this would be great and we can merge them after. Also, we use gerrithub for reviews as its easier to comment on the patch and update new versions. We have updated the repos' configuration. In theory, you should be able to push your patch. Otherwise, we will do the integration ourselves.

You can find the repo here: https://review.gerrithub.io/admin/repos/robinhood-suite/robinhood4,general

Guillaume

Amin000 commented 9 months ago

Sorry, I accidentally deleted the branch, so I created a new one and submitted the code. Can you take a look?