search

robinhood-unofficial / pyrh

Python Framework to make trades with the unofficial Robinhood API
https://pyrh.readthedocs.io/en/latest/
MIT License
1.78k stars 603 forks source link

Added optional qr_code argument to SessionManager #216

Closed scottgl9 closed 4 years ago

scottgl9 commented 4 years ago
adithyabsk commented 4 years ago

@scottgl9 Thanks for creating a pull request. A few quick questions here. The reason I didn't include the qr code was that it seems that you would not be able to log into Robinhood anywhere else since the mfa source would essentially become this app. That's why using Google Authenticator (or another central mfa authority) would be the preferred way of logging in.

adithyabsk commented 4 years ago

Nevertheless, the class now allows you to only need to input that password once and the class will auto-refresh the oauth tokens as long as it is running.

adithyabsk commented 4 years ago

Additionally, I'm not sure if the current implementation would work once the oauth token expires. (ie after 1 day)

scottgl9 commented 4 years ago

Alright I understand. By the way, are you planning to add crypto trading support to your robinhood python library?

adithyabsk commented 4 years ago

@scottgl9 That could certainly be on the roadmap. I wanted to fix the login issues first. I think my next goal is to clean up to trade stocks, then options. If you could create a feature request, we can track progress there.

adithyabsk commented 4 years ago

I'm closing this PR but if something changes feel free to re-open.