robinhood-unofficial / pyrh

Python Framework to make trades with the unofficial Robinhood API

https://pyrh.readthedocs.io/en/latest/

MIT License

1.78k stars 603 forks source link

fix: updated historicals url build #229 #230

Closed samueleishion closed 4 years ago

samueleishion commented 4 years ago

Checklist

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.
[x] I've added a news fragment of my changes with the name, "{ISSUE_NUM}.{feature|bugfix|doc|removal|misc}""

Related Issue

Fixes: #229

Description

Using get_historical_quotes yields an error given the way a URL is being concatenated with a str. Updated the code to use the URL method .with_query in order to build a URL with params.

adithyabsk commented 4 years ago

I think this PR is fine, I need to figure out the macOS caching fails.