robinhood-unofficial / pyrh

Python Framework to make trades with the unofficial Robinhood API
https://pyrh.readthedocs.io/en/latest/
MIT License
1.77k stars 603 forks source link

place_stop_loss_sell_order conflict with submit_sell_order sanity check #286

Closed doudoujay closed 3 years ago

doudoujay commented 3 years ago

Checklist

Description

place_stop_loss_sell_order is conflicting with submit_sell_order

Steps/Code to Reproduce

inside submit_sell_order

       if trigger == "stop":
            if stop_price is None:
                raise (
                    ValueError(
                        "Stop order has no stop_price in call to submit_sell_order"
                    )
                )
            if price <= 0:
                raise (
                    ValueError(
                        "Stop_price must be positive number in call to "
                        "submit_sell_order"
                    )
                )

Do you mean if stop_price <= 0?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

Closing this issue automatically because it has not had any activity since it has been marked as stale. If you think it is still relevant and should be addressed, feel free to open a new one.

sunil3590 commented 2 years ago

@doudoujay i think you are right. I faced the same issue. What did you end up doing?