search

robinhood-unofficial / pyrh

Python Framework to make trades with the unofficial Robinhood API
https://pyrh.readthedocs.io/en/latest/
MIT License
1.77k stars 603 forks source link

fix: updated .toml and lock file dependencies #307

Closed jhirschibar closed 1 year ago

jhirschibar commented 1 year ago

Checklist

Related Issue

Fixes #306, updates certifi and pytz to more recent versions.

Description

Versions of certifi and pytz within pyrh were outdated by a few years. These packages follow date structure versioning instead of semantic versioning. Packages using updated versions (eg: 2022's version instead of 2020's version) signals incompatibility within Poetry's dependency resolver when combined with pyrh, so I updated them within pyrh's pyproject.toml and re-wrote the lock file.

adithyabsk commented 1 year ago

seems like a ci error--I'll fix it when I have some time, otherwise feel free to take a stab at it

jhirschibar commented 1 year ago

seems like a ci error--I'll fix it when I have some time, otherwise feel free to take a stab at it

Pre-commit Action was failing to build isort environment. Throwing the error below, so I updated isort to 5.12 in pyproject.toml and the pre-commit-config and it worked locally. 


[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/runner/.cache/pre-commit/repog4yvbyy7/py_env-python3/bin/python', '-mpip', 'install', '.', 'toml')
return code: 1
...
RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'```
adithyabsk commented 1 year ago

Merged, thanks for the contribution--until I cut a release, feel free to install from mainline

jhirschibar commented 1 year ago

@adithyabsk I'm happy to cut the release and save you the time, but not sure I have credentials for that

adithyabsk commented 1 year ago

@jhirschibar no worries, I cut a new release, we had a couple of other minor tweaks that needed to get in either way: https://github.com/robinhood-unofficial/pyrh/releases/tag/v2.1.2