robinhood-unofficial / pyrh

Python Framework to make trades with the unofficial Robinhood API
https://pyrh.readthedocs.io/en/latest/
MIT License
1.78k stars 603 forks source link

Move unwanted print statement to `input` #315

Closed thevickypedia closed 7 months ago

thevickypedia commented 7 months ago

Checklist

Related Issue

Description

Moved the "Input mfa code:" within input statement

Reason: There is no reason for the print statement to be stand-alone, as it will eventually be printed in the console for standard input in python

I'd also prefer pyrh using logger instead of print statements all over, but I'm not sure how you feel changing it. If it is a 👍🏻 , I can create a follow up PR for that as well. It doesn't need to be a static logger, pyrh can use a default logger and still give an option to users to bring their own formatted logger.

adithyabsk commented 7 months ago

Sure, happy to accept contributions to this project. But, fair warning--it's in maintenance mode these days. If you intend to land logic changes, would appreciate it if you could take a look at CI as well so we can merge with confidence.