Open jddsc opened 6 years ago
Thanks for reporting this. You are right, this is indeed a bug.
The last range should indeed be WindowRange(start=990, end=1110)
but the problem is that for start in range(int(earliest), int(curr.end), int(self.step))
loops until 1110
. We need to fix this to be min(int(curr.end), int(timestamp))
.
Checklist
master
branch of Faust.Steps to reproduce
docker-compose.yml
Run the following script
Evaluate
somefile.txt
1st line:Expected behavior
I am expecting an incrementation only in
WindowRange
(s) that matches themessage.timestamp
:Actual behavior
All
WindowRange
(s) are incremented.Further Analysis
.ranges
is producing windows where the timestamp is not included. The.ranges
code seems to assume that_timestamp_window
would return the “older” window that contains the timestamp (in this case it would beWindowRange(start=900.0, end=1020.0)
) and is therefore generating more ranges than expected.Versions