added take_events() function

robinhood / faust

Python Stream Processing

Other

6.72k stars 535 forks source link

added take_events() function #661

Open itsmesrds opened 3 years ago

itsmesrds commented 3 years ago

Description

This PR adds a new function stream.take_events() which will return events()

https://github.com/robinhood/faust/issues/660 (Fixes #660)

CLAassistant commented 3 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: sivasai-quartic
:x: itsmesrds
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

fr-ser commented 3 years ago

Since returning events is a requirement for manual acknowledgment, how about we include the "fix" for noack-streams as well?

I linked the bug in the feature request for this and here would be a code example of take with consideration for noack https://gist.github.com/fr-ser/347c00e0026cd7941e1d73fd36e54887

qbzenker commented 3 years ago

As a user of Faust, I would also like this PR to be approved/merged. The take_events functionality is super useful.