search

robinhood / faust

Python Stream Processing
Other
6.72k stars 535 forks source link

fixes #681 #701

Closed jaychoww closed 1 year ago

jaychoww commented 3 years ago

Note: Before submitting this pull request, please review our contributing guidelines.

Description

fixes #681 by remove ack_id that has been committed in _new_offset()

NOTE: All patches should be made against master, not a maintenance branch like 3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in that version series.

If it fixes a bug or resolves a feature request, be sure to link to that issue via (Fixes #4412) for example.

patkivikram commented 3 years ago

This project is not maintained. Can you please create this PR against https://github.com/faust-streaming/faust?

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

jaychoww commented 1 year ago

This project is not maintained. Can you please create this PR against https://github.com/faust-streaming/faust?

it seems you fixed this issue