search

robinhood / faust

Python Stream Processing
Other
6.7k stars 538 forks source link

chore: Closes https://github.com/robinhood/faust/issues/757 #773

Open dmaljovec opened 1 year ago

dmaljovec commented 1 year ago

Description

Closes https://github.com/robinhood/faust/issues/757

I'd like to use this package in conjunction with other tools such as black that depend on a more modern version of the click library. As a shot in the dark, I am assuming that the upper bound pin on click was conservatively created before that version was released? This seems to be the case given the history of this line in the default requirements and the release of click 8.0.0 being two years later.

In the spirit of that, I bumped to the next (yet to be released) major semver and ran the test suite on a local build using Python 3.7.14 and click==8.1.3, and received the following results:

Results (28.03s):
    2022 passed
       6 skipped

Full disclosure, I did not vet this codebase heavily to see if there are any concerns with this major version bump, but in my own private projects that are pretty vanilla usage of click I have been able to make the upgrade pretty transparently. I am mostly relying on the test suite you have here to capture any breakages. I did a very quick scan of the release notes of click 8.0 and it mostly seems like they are making the switch due to dropping python 2 and 3.5 support. I will note that they do not say anything special in their upgrade document for version 8.0 or beyond: https://click.palletsprojects.com/en/8.1.x/upgrading/ which is likely a good sign. Someone with more intimate knowledge of this codebase may want to take a closer look at the extensive release notes just in case: https://click.palletsprojects.com/en/8.1.x/changes/#version-8-0-0

dmaljovec commented 1 year ago

Thank you for your consideration!