search

robinhood / spark

A simple Android sparkline chart view.
Apache License 2.0
1.28k stars 157 forks source link

Fixes fill animation path #56

Open cammace opened 6 years ago

cammace commented 6 years ago

Closes #48

This PR fixes the "zigzag" animation when the fill is enabled. In the gif below, you'll notice the line stroke consumes the entire shape rather than just the top. Not sure if this is okay or a fillPath should be created that uses a separate Paint instance without stroke.

ezgif com-video-to-gif 1

cammace commented 6 years ago

Noticed when fill wasn't enabled, the line would draw from coordinates 0,0 within the sparkView. commit 8b58884 fixes this.

cammace commented 6 years ago

CI is failing since #64 got merged, classic case of the:

Failed to install the following Android SDK packages as some licences have not been accepted.

🙄