Disappearing characters

robinhood / ticker

An Android text view with scrolling text change animation

https://medium.com/robinhood-engineering/hello-ticker-20eaf6e51689

Apache License 2.0

4.38k stars 462 forks source link

Disappearing characters #6

Closed jinatonic closed 7 years ago

jinatonic commented 8 years ago

Repro:

Slow down animation.
Start with a short string (e.g. "1234")
Continuously set target to a longer string (e.g. "12345") before the animation completes.
Observe that some characters start popping up mid-frame rather than smoothly scroll from top/bottom.

Ameya03 commented 8 years ago

which devices did you used for testing ?

jinatonic commented 8 years ago

I think I observed this behavior on the Nexus 4 emulator.

Perry-RU commented 8 years ago

I haven't taken a deep look at the repo code but it does seem as though many of these issues only occur when a change has occurred before the animation has completed. That might be a nice place to start and perhaps put a safe guard patch up to protect against this.

jinatonic commented 7 years ago

This is fixed by #47