update to 1.0.19, removed headers

robinlinden / libsodium-cmake

Wrapper around the libsodium repository providing good integration with CMake when using FetchContent or adding it as a submodule.

ISC License

33 stars 31 forks source link

Open CPunch opened 6 months ago

CPunch commented 6 months ago

closes #5 and #26

been using your project for a while now, thank you!

let me know if you need any changes

CPunch commented 6 months ago

sure! thats something i can get started on tomorrow, and yeah you called it I wrote it while on linux haha

feel free to restructure it yourself if I don't get to it, thanks!

CPunch commented 6 months ago

looks like MSVC will need a bit more work, still looking into it haha

robinlinden commented 6 months ago

No rush! Let me know if you hit a wall with it and I can take a look. :P

CPunch commented 6 months ago

currently hit a wall haha, some things I've tried doing (although might just be spinning my wheels):

verified that the missing symbols are actually being compiled in the translation units
double checked sodium isn't supplying any special definitions to MSVC
verified it wasn't just some weird side effect of removing the headers for MSVC (commit 65de118362a4caf2a813645d6660c49557876f62 works for MSVC)

let me know if you have any other ideas or if you can check as well, thank you!