robinloeffel / esbuild-plugin-eslint

Lint your esbuild bundles with eslint. 🧐
https://npmjs.com/esbuild-plugin-eslint
MIT License
7 stars 7 forks source link

0.3.1: types missing: throwOnWarning, throwOnError #7

Closed glensc closed 1 year ago

glensc commented 1 year ago
✖ tsc                    
bin/build-eslint.ts:19:7 - error TS2345: Argument of type '{ throwOnWarning: boolean; throwOnError: boolean; }' is not assignable to parameter of type 'esbuildPluginEslintOptions'.
  Object literal may only specify known properties, and 'throwOnWarning' does not exist in type 'esbuildPluginEslintOptions'.

19       throwOnWarning: true,
         ~~~~~~~~~~~~~~~~~~~~
robinloeffel commented 1 year ago

fixed in https://github.com/robinloeffel/esbuild-plugin-eslint/commit/c267a71e230197b2e5cdca88912dde58ddd5d0b3