robinmanuelthiel / flexbutton

Flexible button control for Xamarin.Forms
MIT License
240 stars 34 forks source link

Update ColorOverlayEffect.cs #59

Closed greatvova closed 6 years ago

greatvova commented 6 years ago

Fixed bug when EmbeddedResource couldn't be used as Icon. More detailed described in bug_report.md.

robinmanuelthiel commented 6 years ago

From your Bug report:

Describe the bug FlexButton cannot use icons on iOS if they are embeddedresources. It works correct if I put icon to platform-specific folder(Resources/drawable) or don't use icon at all;

To Reproduce Steps to reproduce the behavior:

Add some flex button in xaml code; Add some .NET Standard project for various resources(In my case it is called Resources); Add some icon in Resources project(i put them in "Images" folder); Add helper to resources project, that will return ImageSource like this: "return ImageSource.FromResource(string.Format("My.Solution.Namespace.Resources.Images.{0}",imageName));" Add MarkupExtension, that will return Source for icon like this: "public object ProvideValue(IServiceProvider serviceProvider) { if (Source == null) return null; return ImageHelper.GetImage(Source); }"; Set Icon property of FlexButton to extension: "Icon="{extns:ImageResource sample.png}""; 7.Get NullReferenceException while page loading; Expected behavior Button should work with embedded images from other projects just like it does with ones in usual places(Platform specific folders)

Please complete the following information:

Which version of the FlexButton do you use?(0.8.0) Which version of Xamarin.Forms do you use?(3.1.0.637273) Which OS are you talking about?(iOS 11.4.1)

robinmanuelthiel commented 6 years ago

Great stuff, haven't realize that, thanks!