Clicked event triggered even when dragged outside

robinmanuelthiel / flexbutton

Flexible button control for Xamarin.Forms

MIT License

240 stars 34 forks source link

Clicked event triggered even when dragged outside #63

Closed mhouSK closed 3 years ago

mhouSK commented 6 years ago

Describe the bug When clicking on a FlexButton, the Clicked event is triggered even if the user drags its finger outside the button to cancel the action.

To Reproduce

Create a simple FlexButton and implement the Clicked event.
Click on the button and drag outside its frame. Release.
The Clicked event is triggered.

Expected behavior The Clicked event should not be triggered.

Please complete the following information:

Which version of the FlexButton do you use? 0.8.0
Which version of Xamarin.Forms do you use? 3.1.0
Which OS are you talking about? Android 8.1, iOS 11.4

robinmanuelthiel commented 5 years ago

Interesting. Would you still expect the TouchedUp to get triggered? I would say yes, right?

mhouSK commented 5 years ago

I would say that TouchedDown is triggered because the user pressed on the button, but TouchedUp is not because the user left the button before removing its finger.

Clicked should only be triggered in case of a TouchUpInside (finger released inside the bounds of the button after a TouchDown of this same button).

Thanks for your help!

robinmanuelthiel commented 5 years ago

Maybe we should introduce events like TouchedDownInside, TouchedUpOutside and so on. Then everyone can decide what fits his or her needs.

gaffkins commented 5 years ago

Hi. It's any chance to update? In scroll view is unusable.

robinmanuelthiel commented 3 years ago

After years, I finally found the time to work on that project again. With the 0.12.0 release, this should be fixed.