search

robinmanuelthiel / flexbutton

Flexible button control for Xamarin.Forms
MIT License
240 stars 34 forks source link

Icon isssues #9

Closed IeuanWalker closed 6 years ago

IeuanWalker commented 6 years ago

Control version: 0.4.0

Hi, great control I just have 2 issues.

  1. Is there going to be an update to allow SVG as an icon?
  2. Is there a way to change the default position of the icon with text i.e. at the moment it defaults to the left of the text but we need it on the right.
robinmanuelthiel commented 6 years ago

Good catch, thanks for the feedback. Will look into options for that and add it to my backlog. Icon position totally makes sense and shouldn't be too hard to implement. SVGs will be more work but I was already thinking of switching over to SkiaSharp, so let's see...

IeuanWalker commented 6 years ago

@robinmanuelthiel Great that's awesome, thanks.

Depechie commented 6 years ago

Added the orientation in Pull https://github.com/robinmanuelthiel/flexbutton/pull/14 No SVG yet :) If merged, better to update the readme.md of the project to show new IconOrientation property in API.

robinmanuelthiel commented 6 years ago

Awesome work, thanks a lot for all your contributions! Will add you as a contributor on the welcome page!

robinmanuelthiel commented 6 years ago

Fixed in latest 0.5.0 Release