robinostlund / homeassistant-volkswagencarnet

Volkswagen Carnet Component for home assistant
GNU General Public License v3.0
340 stars 63 forks source link

v4.6.0 #607

Closed stickpin closed 7 months ago

stickpin commented 8 months ago

Change log:

Type of change

stickpin commented 8 months ago

Hi @robinostlund, Please merge this one.

stickpin commented 8 months ago

Hi @robinostlund,

Please allow me to merge the PR myself without additional reviews, unfortunately, there are no other active developers anymore, and PRs are getting stuck for no reason. If you don't want to, it's also fine, please let me know and I will start running a separate repo, the same way as skodaconnect is running for example, with the future evolution of Volkswagen Connect. I prefer not to do it but it's your call.

Thanks. :)

stickpin commented 7 months ago

3 weeks passed and no response. I guess @robinostlund is focused on something more important. I will start running a separate repo to remove the dependency and unblock the evolution of VW Connect (even though, I don't like this idea).

robinostlund commented 7 months ago

@stickpin sorry i totally missed your message, i have been starting a new job so it has been alot of other things to take care of :) i can try to change the settings of this repo so you should be able to merge by yourself.

robinostlund commented 7 months ago

I removed so it doesn't require a review now so i think that should be enough, please try @stickpin

stickpin commented 7 months ago

@robinostlund we need to find a better way to communicate... :) If it's ok, drop me your phone number to stickpins at gmail dot com and we will connect via some messenger (Signal, Threema, Telegramm or WhatsApp)

And yes, I can merge now with a review. :)

virtualdj commented 7 months ago

even though, I don't like this idea

Yeah, having this original repo to survive (and be updated) is also great to keep the history of bugs/feature requests that would disappear in a fork.

Thanks to both of you!

i have been starting a new job

Congratulations for your new job!