Add requirements and set version in manifest of custom component

robinostlund / homeassistant-volkswagencarnet

Volkswagen Carnet Component for home assistant

GNU General Public License v3.0

303 stars 61 forks source link

Add requirements and set version in manifest of custom component #644

Closed peter-vanpoucke closed 5 days ago

peter-vanpoucke commented 5 days ago

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature
[ ] Code quality improvements to existing code or addition of tests

Description

I wanted to install the component manually. The README proposes to install the requirements using pip, but that didn't seem to work for me using SSH. I was able to add the integration when I added the requirements to the manifest of the custom component. I've also set the version of the component.

stickpin commented 5 days ago

Hi @peter-vanpoucke,

Thanks for the PR, but it's not required. The version is added by the GitHub actions script during the release: https://github.com/robinostlund/homeassistant-volkswagencarnet/blob/master/.github/workflows/release.yaml

Check manifest in the release.

Best Regards! :)

peter-vanpoucke commented 5 days ago

Makes sense 😅. To install the repo, I cloned the repo and checked out the tag instead. Thanks for the info.