search

robinostlund / volkswagencarnet

A python library for volkswagen carnet
GNU General Public License v3.0
65 stars 37 forks source link

Add pre-commit dependency and configuration #172

Closed milkboy closed 2 years ago

milkboy commented 2 years ago

image :heart:

robinostlund commented 2 years ago

LOVELY ❤️

codecov-commenter commented 2 years ago

Codecov Report

Merging #172 (9a15fea) into master (6a3054b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   32.59%   32.59%           
=======================================
  Files           5        5           
  Lines        2565     2565           
  Branches      486      486           
=======================================
  Hits          836      836           
  Misses       1648     1648           
  Partials       81       81
Flag Coverage Δ
unittests 32.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a3054b...9a15fea. Read the comment docs.

milkboy commented 2 years ago

LOVELY heart

Got annoyed by actions failing after some tiny change. So this should help in avoiding those annoyances (well, the docstrings might take a while to iron out completely)

milkboy commented 2 years ago

oh, one more thing.. how should the pre-commit repository versions be handled? There seems to be a couple of ways:

robinostlund commented 2 years ago

Good question, i havent used pre-commit before, what do you say? maby we should test the different ways? :)

milkboy commented 2 years ago

There's a first time for everything :D Never used it before either, but know several projects that have good experience with it. Definitely simplifies and visualizes things nicely. Would maybe try the pre-commit.ci approach to see if it's any good. As a bonus, it should (by default at least) autofix any new PRs in the same way as the local git hook if I understood it correctly.