robinostlund / volkswagencarnet

A python library for volkswagen carnet
GNU General Public License v3.0
66 stars 38 forks source link

Fix code scanning alerts (1/x) #176

Closed milkboy closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #176 (258e9b0) into master (732dbb4) will increase coverage by 0.92%. The diff coverage is 65.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   32.61%   33.54%   +0.92%     
==========================================
  Files           5        6       +1     
  Lines        2566     2555      -11     
  Branches      486      470      -16     
==========================================
+ Hits          837      857      +20     
+ Misses       1648     1625      -23     
+ Partials       81       73       -8     
Flag Coverage Δ
unittests 33.54% <65.11%> (+0.92%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
volkswagencarnet/vw_utilities.py 100.00% <ø> (ø)
volkswagencarnet/vw_connection.py 12.60% <37.50%> (-0.03%) :arrow_down:
volkswagencarnet/vw_dashboard.py 56.90% <54.16%> (+0.34%) :arrow_up:
volkswagencarnet/vw_vehicle.py 36.29% <73.07%> (+1.50%) :arrow_up:
volkswagencarnet/vw_exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 732dbb4...258e9b0. Read the comment docs.

milkboy commented 2 years ago

image

milkboy commented 2 years ago

more than halfway there :smile: the rest in a new PR when there is time