robinostlund / volkswagencarnet

A python library for volkswagen carnet
GNU General Public License v3.0
65 stars 37 forks source link

Fix code scanning alerts 2 #178

Closed milkboy closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #178 (07a47da) into master (892afd3) will increase coverage by 2.67%. The diff coverage is 76.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   33.54%   36.22%   +2.67%     
==========================================
  Files           6        6              
  Lines        2555     2504      -51     
  Branches      470      432      -38     
==========================================
+ Hits          857      907      +50     
+ Misses       1625     1540      -85     
+ Partials       73       57      -16     
Flag Coverage Δ
unittests 36.22% <76.43%> (+2.67%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
volkswagencarnet/vw_connection.py 12.60% <0.00%> (ø)
volkswagencarnet/vw_vehicle.py 42.25% <79.33%> (+5.95%) :arrow_up:
volkswagencarnet/vw_utilities.py 96.15% <87.50%> (-3.85%) :arrow_down:
volkswagencarnet/vw_dashboard.py 56.47% <0.00%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 892afd3...07a47da. Read the comment docs.

milkboy commented 2 years ago

:partying_face: :tada:

Don't "think" I broke too much stuff here, but can't quite test everything (especially the stuff my car can't do). Will add more tests at some point though, so that most stupid errors like accidentally inverting an if-else or something should be caught by unit tests

image