robinostlund / volkswagencarnet

A python library for volkswagen carnet
GNU General Public License v3.0
66 stars 38 forks source link

Add timer programming feature #179

Closed milkboy closed 2 years ago

milkboy commented 2 years ago

Relates to https://github.com/robinostlund/homeassistant-volkswagencarnet/issues/352

WIP

A little bit of a placeholder still, but goal is to implement some functionality for timer programming etc.

Some data is probably different, if there is an aux heater or something attached, so will probably ask for volunteers to provide API responses at some point :wink:

Timers

Misc settings

Locations (wishlist)

The whole departure schedule request is sent on each call to the backend, so including any changes to the charging profiles will update them also

codecov-commenter commented 2 years ago

Codecov Report

Merging #179 (6535ede) into master (1991b21) will increase coverage by 3.58%. The diff coverage is 54.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   36.22%   39.80%   +3.58%     
==========================================
  Files           6        7       +1     
  Lines        2504     2733     +229     
  Branches      432      469      +37     
==========================================
+ Hits          907     1088     +181     
- Misses       1540     1578      +38     
- Partials       57       67      +10     
Flag Coverage Δ
unittests 39.80% <54.57%> (+3.58%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
volkswagencarnet/vw_vehicle.py 45.24% <33.02%> (+2.99%) :arrow_up:
volkswagencarnet/vw_connection.py 12.78% <37.20%> (+0.18%) :arrow_up:
volkswagencarnet/vw_dashboard.py 56.77% <55.26%> (+0.30%) :arrow_up:
volkswagencarnet/vw_timer.py 72.41% <72.41%> (ø)
volkswagencarnet/vw_utilities.py 94.02% <86.66%> (-2.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1991b21...6535ede. Read the comment docs.

JBoye commented 2 years ago

Looks very nice! Let us know when you have something to test 👍

milkboy commented 2 years ago

Looks very nice! Let us know when you have something to test +1

Sure. Quite a few wrinkles to iron out still before it's "production" ready though :wink: