search

robinostlund / volkswagencarnet

A python library for volkswagen carnet
GNU General Public License v3.0
65 stars 36 forks source link

Remove Duplicate Entries for Doors and Trunk Lock #219

Closed stickpin closed 9 months ago

stickpin commented 9 months ago

Remove Duplicate Entries for Doors and Trunk Locked Sensors.

This is how it looks before the fix: Screenshot 2023-11-29 at 23 45 28

stickpin commented 9 months ago

@oliverrahner forgot to remove trunk_locked_sensor and door_locked_sensor from the dashboard.py.

oliverrahner commented 9 months ago

It's probably not a good idea to remove them. The error that I made is to not correctly adapt the supported checks: the *_sensor entities should be supported if remote lock/unlock isn't supported, the other entities if they are. So _sensor is the read-only entity, the one without is the read/write entity.