Next stable

[oliverrahner]

This is a clean up of the rework-api-after-carnet branch, which got a bit out of hand 😏 It is based off of the last beta tag v4.4.64-beta2 and contains

• the login and re-login race condition fix from @stickpin
• the response examples from myself
• the refresh_token fix from myself
• some clean-ups from myself and a fix for them from @stickpin
• removal of useless services in polling from myself

I explicitly leaves out all the fixes around parking_time, which doesn't seem to work yet, and the rate limiting workarounds, which hopefully shouldn't be necessary after the race condition fixes @stickpin made.

@stickpin @robinostlund I propose to test this a bit locally, also addressing some of the more code-versed guys from the bug threads which can deploy this pre-release and then make a beta from it, treating it as a release candidate.

[oliverrahner]

Side note: The VW API seems to be down again :-/

[stickpin]

Side note: The VW API seems to be down again :-/

yes, starts receiving 502 around this time: 2023-12-07 16:28:41.958

[stickpin]

@oliverrahner I cannot fully check it on my end as it's lacking a vehicle_moving sensor fix. But I provided two fixes for this revision of code.

[oliverrahner]

I merged your PR, it was very concise now. Thanks again!

[robinostlund]

@oliverrahner just tag me here when you and @stickpin agrees on when this is ready to be released as stable or beta 😊

[enoch85]

Would be nice if this could be merged as at least beta before Monday as many users with electric cars have a hard time charging them without the fixes proposed here...

Thanks!

[stickpin]

hi @oliverrahner. all good? are you planning to merge the PRs and trigger a new beta? or should I take over?

[enoch85]

@stickpin We're all waiting for a new release. Please make it beta at least. :)

[stickpin]

@enoch85 unfortunately I cannot. Only @oliverrahner or @robinostlund can merge the waiting PRs and create a new beta.

[stickpin]

@robinostlund not sure what happened to @oliverrahner... hopefully vacation or something. :) while we are waiting... can you please merge these two PRs into this next stable branch: https://github.com/robinostlund/volkswagencarnet/pull/228, https://github.com/robinostlund/volkswagencarnet/pull/229 and after that trigger a new beta?

[robinostlund]

@stickpin done 😄 , btw do you have a buy me a coffee url? Would like to add it to the release notes 😄

[stickpin]

@stickpin done 😄 , btw do you have a buy me a coffee url? Would like to add it to the release notes 😄

Thanks! Well, never had one before, but I added one to my GitHub profile just in case. 😊 I am doing it for fun, so it's really not required. You did the main job, we are just keeping the light on. 💡😄

[oliverrahner]

Hey @stickpin,

I didn't disappear :) I just didn't find any time in the past days to do any other than my day job and family... Haven't looked through everything that happened, but great to see that the next beta is out :)

[stickpin]

@oliverrahner good to see you back. :) To summarize, there are two new PRs, one solves the token refresh flow (https://github.com/robinostlund/volkswagencarnet/pull/229). Another one is the new API Status sensors: https://github.com/robinostlund/volkswagencarnet/pull/228. Very useful taking into consideration how VW services are stable nowadays. :)

[stickpin]

@robinostlund if you have time, please trigger a new beta.

FYI @oliverrahner

[robinostlund]

@robinostlund if you have time, please trigger a new beta.

FYI @oliverrahner

Sure, will do it now 😄

[stickpin]

@oliverrahner seems like the last two things I can take care of with my VW account are "Force Data Refresh" and code clean-up. I don't have an account with enabled actions. I use a basic account without a WeConnectPlus subscription.

In any case, I will be off for the next two or three days, so I won't be able to work on it.

[enoch85]

I think this is pretty stable "as is". I vote for making a stable release, and add tweaks in coming versions. That would also give a wider spread of use with this refactored code, which in turn would generate more users on the new code, and possibly more bug reports for the remaining issues.

What do you say @robinostlund @stickpin @oliverrahner?

[oliverrahner]

I would agree, @enoch85 @robinostlund Should I put together a release message to let people know what exactly is supposed to work and what not?

[robinostlund]

@oliverrahner that would be awesome if you could do that so i can add it to the integration release 😄

[oliverrahner]

Text suggestion:

This release contains a complete overhaul of the Volkswagen API after they have switched off the old "Carnet" app. The integration is now usable again to a certain degree, so we wanted to make the current status available to all users, even though we have not yet implemented all features we wanted and that were already present before.

What is working:

• most entities should be available again, providing insight into your car almost like before
• we now provide information on the current status of VW's API, as it seems to be quite instable and sometimes it is not clear whether an error is caused by the integration itself or just because the API is unavailable again

What is not yet working:

• reading: times and profiles not available yet
• all control features (lock/unlock, climatisation/parking heater, timer and profiles, charging...)

We are still working on getting everything working again. In the meantime, if you encounter any errors apart from the missing features mentioned above, feel free to report them.

@stickpin: Anything to add?

[stickpin]

Text suggestion:

This release contains a complete overhaul of the Volkswagen API after they have switched off the old "Carnet" app. The integration is now usable again to a certain degree, so we wanted to make the current status available to all users, even though we have not yet implemented all features we wanted and that were already present before. What is working:

• most entities should be available again, providing insight into your car almost like before
• we now provide information on the current status of VW's API, as it seems to be quite instable and sometimes it is not clear whether an error is caused by the integration itself or just because the API is unavailable again

What is not yet working:

• reading: times and profiles not available yet
• all control features (lock/unlock, climatisation/parking heater, timer and profiles, charging...)

We are still working on getting everything working again. In the meantime, if you encounter any errors apart from the missing features mentioned above, feel free to report them.

@stickpin: Anything to add?

no, it looks good. :)

Is there anything I can help with? I cannot really work on actions as I don't have a vehicle where I can test it. If you have some tcpdump/wireshark/charles proxy/etc traces that you can share with me, I can work on implementing some missing functionality but people will have to test it.

[enoch85]

We are still working on getting everything working again.

Maybe: We are still working on getting everything up an running again.

[robinostlund]

I think the text is good 👍 should we merge it to master @oliverrahner ? 😄

[oliverrahner]

Yes. There might still be issues, but we will only discover them once we get a larger user base with a fresh perspective.

[oliverrahner]

Is there anything I can help with? I cannot really work on actions as I don't have a vehicle where I can test it. If you have some tcpdump/wireshark/charles proxy/etc traces that you can share with me, I can work on implementing some missing functionality but people will have to test it.

@stickpin I do have access to a fully electric car from a fellow user, but I lost the hybrid I had access to due to a mistake on my side :-/ We probably need to find some more people willing to hand out their credentials (and that accept us playing around with their cars' settings 🙂) to get work done.

[stickpin]

@oliverrahner yes... I asked for credentials in the BETA thread on Friday and then deleted my message because it sounded strange. :))) Have no clue how to handle it. :)

[chrisandsally]

Hi,@stickpin I have a Hybrid, if you want the credentials? Happy to test etc

[stickpin]

@chrisandsally Yes, it will be helpful! :) you can send me over email: stickpins at gmail dot com

I will work first on "read sensors", once I reach actions, I will align with you what and when I can test.

Thanks for your help! :)

[enoch85]

Thank you!!!! You guys rock! 🪨🎸🥇