search

robinostlund / volkswagencarnet

A python library for volkswagen carnet
GNU General Public License v3.0
65 stars 36 forks source link

Re-enable controls #239

Closed oliverrahner closed 7 months ago

oliverrahner commented 8 months ago

Re-implementation of the controls

stickpin commented 8 months ago

@oliverrahner I am unsure if I understand the difference between "Auxiliary Climatisation" and "Electric Climatisation". I am working with PHEV Tiguan now and in the original VW app you can enable Auxiliary Climatisation in the settings but not as an On/Off switch. Do you know the difference? :)

I will stop working on rest climatization functionality until I understand the logic. Maybe EV acts differently, but I don't have access to one.

I will focus on re-enabling Horn & Turn Signals.

In any case, it's Christmas/New Year time now, so not sure how much time I will have to work on it in the next two weeks. Maybe it makes sense to release a new Beta with those two switches enabled, to collect some feedback from other users.

oliverrahner commented 8 months ago

I don't know the difference either :-/ I hoped it would get clearer with access to more different vehicles, but I haven't found the meaning yet, and if they are mutually exclusive or might be part of the same car.

@robinostlund could you create a beta from this branch?

I'll be on holiday for a week now, with little to no time to work on this.

Wish you all a Happy Christmas :)

robinostlund commented 8 months ago

I don't know the difference either :-/ I hoped it would get clearer with access to more different vehicles, but I haven't found the meaning yet, and if they are mutually exclusive or might be part of the same car.

@robinostlund could you create a beta from this branch?

I'll be on holiday for a week now, with little to no time to work on this.

Wish you all a Happy Christmas :)

Sure will release a new beta version 😄 thank you for all your help and have an awesome christmas 🎅

ilkkasaa commented 8 months ago

I am unsure if I understand the difference between "Auxiliary Climatisation" and "Electric Climatisation".

Is "Auxiliary Climatisation" same thing as "Auxiliary heater"?

In my Arteon PHEV there are following settings in the Volkswagen app's Air Conditioning settings: photo_2023-12-22_09-53-15

Auxiliary heater is the one that only heats and runs on gasoline instead of electricity.

mrandt commented 8 months ago

Just to second what @ilkkasaa commented re the "auxiliary" heater:

The auxiliary heater is a gasoline powered heater which had to be ordered as an add-on (about 1.000 €). I believe it is made by Webasto. Naturally, it is only an option in PHEV.

I have a Passat B6 GTE PHEV (Model Type C3) in Germany and made the mistake of ordering that extra. As the car supports electric climatization (from charger or battery) I hardly ever use the auxiliary heater.

I took a screenshot from German Volkswagen app - here it is labeled "Standheizung":

image

IMHO the terms are also a bit misleading; as climatization (electric) also includes heating or cooling (depending on outside temperature).

oliverrahner commented 8 months ago

Thanks for the input. That should enable us to implement the features accordingly. We only need to check if these features are available in the accounts we have available in the meantime 😅

stickpin commented 8 months ago

Hi @robinostlund,

Please trigger a new beta. Change log:

Thanks! :)

robinostlund commented 8 months ago

Hi @robinostlund,

Please trigger a new beta. Change log:

  • Fix Last connected sensor
  • New Last Data refresh sensor
  • Code Clean-up
  • Re-introduce Force Data Refresh
  • Increase wait intervals to 10 seconds to reduce server hammering

Thanks! :)

Lovely, new beta is released now 😄

stickpin commented 7 months ago

Hi @robinostlund,

Please trigger a new beta. Change log:

Thanks! :)

robinostlund commented 7 months ago

@stickpin new beta released 😄

stickpin commented 7 months ago

Hi @robinostlund,

Please trigger a new beta. The changes are mostly related to VW EVs.

Change log:

FYI @oliverrahner

stickpin commented 7 months ago

@robinostlund Due to continuous reports about not working action, I think it makes sense to disable all "broken" switches. We will re-enable them one by one during the re-implementation progress. Please trigger a new full version, I think it makes sense to release an official version not a beta.

Full Change Log for v4.5.1:

Please use this commit: https://github.com/robinostlund/volkswagencarnet/pull/239/commits/111359f0be329429a3031c4530507fd5aec45798

Thanks! :)

FYI @oliverrahner

robinostlund commented 7 months ago

@stickpin @oliverrahner maby we should merge this PR to master and then work on multiple PR for each feature? Whats your thought about that? 😄

stickpin commented 7 months ago

@robinostlund I agree... It seems to be also a bit more complicated than I was thinking from the beginning. That's why I've disabled the Window Heater switch as well for the time being. We need to invest more time in vehicle "feature" detection.

@oliverrahner what is your view?

oliverrahner commented 7 months ago

@stickpin @robinostlund I agree to the proposal. Honestly, I wasn't following the commits very much over the past weeks 😅 The goal should be that master is usually representing the latest release state. Additional work should then be done in PRs, potentially creating beta releases from specific PRs if necessary.

I would do it that way, unless you have something else on your mind @robinostlund

robinostlund commented 7 months ago

@oliverrahner @stickpin lets start with multiple PR and merge this one to master, @stickpin anything you wan't to commit before i merge this request and release a new version? 😄

stickpin commented 7 months ago

@robinostlund no, I don't have anything new yet. 😀 we can merge. 😀