robinovitch61 / wander

A terminal app/TUI for HashiCorp Nomad
MIT License
442 stars 17 forks source link

Default View starting Wander should be the filter view #101

Closed qwo closed 11 months ago

qwo commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] When I enter wander, as a user I begin to type the name of the Wander Job I want, I hit different keyboard keys when I type a job like "my-super-critical-app" where the letters are taken as keyboard navigation events.

I then remember I have to hit /.

This is similar to the experience with vi or vim where the user needs to remember or learn about insert mode i.

Describe the solution you'd like A clear and concise description of what you want to happen.

When I enter wander, as a user I begin to type the name of the Wander Job I want. As a user I begin typing the nomad job I want and expect it to filter so I can hit enter.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

it might be confusing because if its default filter, entering filter mode might be confusing

image

robinovitch61 commented 1 year ago

@qwo I'm implementing this now. Note that the configuration option I'm adding is called "start-filtering" and will only apply to the first view (either jobs or all tasks). Once you type to filter, hit enter, then hit enter to view the tasks or logs, you'll have to hit / to activate the filter on those subsequent pages (not ALL pages will start with the filter active). Let me know if you find that reasonable.

robinovitch61 commented 12 months ago

Let me know if you find that reasonable.

Going to assume yes, @qwo :)

robinovitch61 commented 12 months ago

Will be included in next release with --start-filtering/WANDER_START_FILTERING=true/wander_start_filtering: True (defaults False)

Can try now from unstable branch with go install github.com/robinovitch61/wander@next

robinovitch61 commented 11 months ago

Released in v0.12.0