search

robinparisi / tingle

⚡ 2kB vanilla modal plugin, no dependencies and easy-to-use
https://tingle.robinparisi.com
MIT License
1.55k stars 185 forks source link

Overflow scroll is just supposed to work? #182

Open denised opened 1 year ago

denised commented 1 year ago

Hi --- I'm using a package that is using tingle, and I found that it wasn't scrolling when the modal content was larger than the screen. I came here to see if there was some setting I should figure out how to inject, but as far as I can tell it is supposed to "just work", yes?

You might want to update the "Big Content? No Problem!" example on the website --- the embedded images are getting zero size, so the content isn't actually all that big. But with a little bit of playing in dev tools I was able to make the content larger, and see the scroll bar appear. (It then worked for me in Chrome, though not in Edge --- in Edge, the scroll bar showed up, but my attempt to click on it dismissed the modal.)

denised commented 1 year ago

FWIW, I just discovered that the package I'm using is showing a scrollbar, it is just very hard to see because it is under a lot of blur. image

galanonym commented 1 year ago

I think they solved it in the newest version. Take a look at #141.