search

robinpaulson / SimpleRT

Simple Reverse Tethering utility for Android
GNU General Public License v3.0
899 stars 101 forks source link

1.1 APK shows up as 1.0 #33

Closed IzzySoft closed 2 years ago

IzzySoft commented 7 years ago

The .apk attached to the 1.1 tag, if installed, shows up as version 1.0. Looking at the package itself, it seems versionCode and versionName are set incorrectly:

package: name='com.viper.simplert' versionCode='1' versionName='1.0' platformBuildVersionName='N'

As there already was a v1.0 before that, versionCode must have been increased – and versionName should reflect the real version number :smile_cat:

So may I suggest to correct that? And when attaching the fixed .apk, please leave it an .apk and do not ZIP it again. Thanks in advance!

IzzySoft commented 7 years ago

Any chance?

vvviperrr commented 7 years ago

hi. i leave 1.0 version in binary to support backward compatibility, so u can use simple-rt cli v1.1 with 1.1 AND 1.0 apk version. so, its not an issue. thanks.

IzzySoft commented 7 years ago

Ah, I see. Just wonder that it's named simple-rt-1.1.apk.zip and its size differes from the one attached to the 1.0 tag. Plus, the comment in the release note says "works only with 1.1 (this) apk version" – which seems to contradict what you just wrote. Maybe you adjust the release comments then, to avoid that confusion? :wink:

Again, just in case I wasn't clear in my initial report: That simple-rt-1.1.apk.zip identifies itself as "v1.0".

robinpaulson commented 2 years ago

@IzzySoft I made a new release, it will likely hit the FD repos in a few days, could you take a look to see if the problem is fixed? I'm still looking around the code, the first month or so since I took over got interrupted by ... life.

IzzySoft commented 2 years ago

When a new version shows up, you can consider the issue solved. When I reported this issue here 4 years ago, the app was in my repo (so I noticed); it no longer is, it's now at F-Droid.org. And someone already updated the metadata yesterday (as this issue was left unanswered for years, updates had been disabled), so it indeed could show up within the next few days. A new build cycle has just started, you can watch it here.

robinpaulson commented 2 years ago

This should be fixed now, I released v1.1.1

Closing, do post if there are any issues related to this

IzzySoft commented 2 years ago

Confirmed: v1.1.1 showed up on F-Droid 2 days ago. Thanks!