search

robinpellegrims / pellegrims

Nx monorepo with open source projects
MIT License
49 stars 21 forks source link

feat: update nx to v19.0.6 #275

Closed arvidboivie closed 5 months ago

arvidboivie commented 6 months ago

Hey, figured I'd give a shot at updating this for Nx 19.

This generates a couple of dependency warnings:

 WARN  Issues with peer dependencies found
.
├─┬ @jscutlery/semver 5.2.0
│ └── ✕ unmet peer @nx/devkit@^18.0.0: found 19.0.4
└─┬ ngx-deploy-npm 7.1.0
  └── ✕ unmet peer @nx/devkit@"^16.0.0 || ^17.0.0 || ^18.0.0": found 19.0.4

@jscutlery/semver seems to have a an update on the way: https://github.com/jscutlery/semver/issues/814 Not sure about ngx-deploy-npm though, it support 18 but is still on 17 itself.

robinpellegrims commented 5 months ago

Could you also fix the following lint error?

/libs/nx-remotecache-s3/package.json 41:5 error The version specifier does not contain the installed version of "nx-remotecache-custom" package: 19.0.0 @nx/dependency-checks

The nx-remotecache-custom version in the buildable libs package.json needs to match the new version in the root package.json.

It can be fixed automatically using nx lint nx-remotecache-s3 --fix

arvidboivie commented 5 months ago

No automatic migrations, the only breaking change in NX was a change in how they bundle env variables: https://nx.dev/blog/2024-05-08-nx-19-release#breaking-change-updating-bundled-environment-variables-to

Will adress your comments during the day!

arvidboivie commented 5 months ago

Not sure what you want to with ngx-deploy-npm and @jscutlery/semver, do we wait for them to support 19?

robinpellegrims commented 5 months ago

Not sure what you want to with ngx-deploy-npm and @jscutlery/semver, do we wait for them to support 19?

Ah yes, I forgot to check if it will be a problem. I'll try and do this later today.

robinpellegrims commented 5 months ago

Not sure what you want to with ngx-deploy-npm and @jscutlery/semver, do we wait for them to support 19?

Ah yes, I forgot to check if it will be a problem. I'll try and do this later today.

Looks good, both dependencies seem to work with the newest version (apart from the warning) so we should be able to upgrade them later.

Thanks again!