search

robinpoort / vanilla-js-responsive-menu

A vanilla JS responsive menu plugin
MIT License
33 stars 5 forks source link

too late for dropdown #4

Closed hans2103 closed 8 years ago

hans2103 commented 8 years ago

When on an iPad I'm not able to click on a submenu item when the parent menu item contains a links The iPad is big enough not to collapse to mobile menu. 

<ul>
  <li>
    <a href="link">parent</a>
    <ul>
      <li><a href="sublink">submenu</a></li>
    </ul>
  </li>
</ul>

I would like to be able to open the dropdown on a single click. And open the link of the parent on a double click.

robinpoort commented 8 years ago

@hans2103 Added support, just update the menu to the latest version. Let me know if this fixes it for you as well.

hans2103 commented 8 years ago

Hard time testing the fix since it also has some CSS changes affecting the height of the menu on tablet view. See screenshot

schermafdruk 2016-03-15 23 48 33
robinpoort commented 8 years ago

@hans2103 I forgot to mention that there's a new SCSS setting that you should enable.

Set $vjsm-multi-level to true to enable the CSS to make it work.

hans2103 commented 8 years ago

@robinpoort I've set $vjsm-multi-level to true to enable the CSS to make it work. Now I have another issue to solve... see screencapture below.

m2-cachemanagement-selectalls

robinpoort commented 8 years ago

@hans2103 You have fixed this right? If so can you close the issue?

hans2103 commented 8 years ago

issue is solved... therefor issue can be closed.