search

robinrodricks / vue3-touch-events

Simple touch events support for vue.js 3
MIT License
216 stars 27 forks source link

Any news about a 4.1.1 release? #19

Closed paulocheque closed 1 year ago

paulocheque commented 1 year ago

Any news about a 4.1.1 release?

robinrodricks commented 1 year ago

Sure, remind me over the weekend.

robinrodricks commented 1 year ago

Published. Can you check if it works?

Tommytrg commented 1 year ago

It's not working. It broke our app in production and we have to spend a whole day looking for an error in our codebase. Please don't release a new version of a package that people is using if you think it could break something. It could break several projects :crying_cat_face:

kirbby commented 1 year ago

ye it breaks...

robinrodricks commented 1 year ago

Why did you update your production app with new library versions without testing in dev? Seems like a foolish move. But yes I will revert.

robinrodricks commented 1 year ago

I only found 2 changes after my first publish

Which one do you think is breaking it?

  1. https://github.com/robinrodricks/vue3-touch-events/commit/a86950bbd9d10f903f5c2646acaab7c8d427111e
  2. https://github.com/robinrodricks/vue3-touch-events/commit/06d81b843c0bfcbad23c67dfd4eb2647620e46df
robinrodricks commented 1 year ago

I have reverted both these commits and republished. Can you guys check and see if it works?

kirbby commented 1 year ago

Reverting obviously fixed it. I will check if i find out which of the changes the problem is.

kirbby commented 1 year ago

I only found 2 changes after my first publish

Which one do you think is breaking it?

  1. a86950b
  2. 06d81b8

The correct replacement for module.exports = { vueTouchEvents } would be export default vueTouchEvents So basically the version before any of the 2 changes was the right one. Probably including "type": "module", in the package.json.