search

robinrodricks / vue3-touch-events

Simple touch events support for vue.js 3
MIT License
216 stars 27 forks source link

Reconsidering the default value for dragFrequency. #41

Open Apkovy opened 2 months ago

Apkovy commented 2 months ago

Hello,

I had quite a hard time finding out, why my animation is jerky after migrating from vue2 to vue3. I am not going into details why, but it was caused mainly by the way the vue3 mounts a mixin, which misled me.

Anyway, please reconsider changing the default value back to vue2 equivalent, whichever it was.

I had to set the dragFrequency to null or 0 to get the smooth animation again.

I think, that my scenario is pretty common, maybe the prevalent one and this was not happy decision.

Thank you.

robinrodricks commented 2 months ago

But firing unlimited events per second is not a good thing.

Apkovy commented 2 months ago

Yes, That's why I always use the requestAnimationFrame inside the movingHandler(drag).

I don't know what is used in vue2 touch events or vue3 touch events, but this would be at least the plausible solution.

Anyway I would just leave it for the developer to handle this and let the vue3 touch events only dispatch the native events as they are firing in the browser. Maybe puting the warning in the docs would be fine.

Thank you anyway for your attention.