robinrojh / pe

0 stars 0 forks source link

sort-weakness and sort-strength vague description #12

Open robinrojh opened 2 years ago

robinrojh commented 2 years ago

image.png

The descriptions are vague because there is no explanation of what the items are sorted based on.

The possible options for sorting are the following:

  1. number of strengths/weaknesses
  2. alphabetical comparisons between individual strengths/weaknesses
  3. compare only the first strength/weakness

However, it is not possible to infer from the User Guide what the sort commands sort based on.

nus-pe-bot commented 2 years ago

Team's Response

The command definition specifies "total strengths/weaknesses". It cannot be inferred from this that it could be an alphabetical comparison (as the word would be "individual" rather than "total" ). It also could not be inferred as "only the first strength/weakness" since the word "total" is used in the definition.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I have stated this as an issue because the word total is not enough of an explanation. By saying total strengths/weaknesses, does it mean the number of them? How can we quantify strengths and weaknesses? It could also mean a strength could be more important than another, as the word "total" does not contain information on what data is compared. If it was the number of strengths/weaknesses, then it should be stated as "total number of strengths/weaknesses" instead.