search

robinrojh / pe

0 stars 0 forks source link

Adding or deleting strength or weakness displays all persons #9

Open robinrojh opened 2 years ago

robinrojh commented 2 years ago

Adding or deleting a strength or weakness refreshes the Contact tab.

Steps to reproduce:

  1. Call a command such as find-p
  2. add or delete a strength or weaknesses
  3. tab is refreshed and shows every person or tasks

Expected: does not refresh the tab as it is not expected to show every persons

Actual: shows every person

soc-pe-bot commented 2 years ago

Team's Response

This is an intended function, as after the user utilizes the find feature in order to locate and modify a particular persons strengths/weaknesses/misc notes, they are not expected to require the filtered list any longer, so it refreshes the list for the sake of efficiency, as adding/deleting a note for a particular person is an expected result after filtering the list, as they would be expected to be looking for a particular person based on their name or team for the sake of making this sort of adjustment.

Furthermore, assigning multiple strengths/weaknesses/miscs is not expected to be performed all at once for a particular person while the target user [a coach/instructor] continues to learn more about that person over time.

The severity has been lowered to "low" for this case as the user can simply re-filter the list and proceed if they need to, although they would rarely need to given the above mentioned reasons (that the target user is not expected to encounter this issue often, if ever).

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is quite a significant inconvenience to the user (even though it does not make the app unusable) as stated in the issue severity explanation. Therefore, it should have been placed in high priority. The User Guide also does not state anything regarding this issue. Therefore, I would like to argue that this is indeed in the scope.

I would disagree that this is just a minor inconvenience. Imagine having a whole soccer team-- that would be 11 + a few more substitute players. In those cases, it would be natural for the user to search for a person using the name or noteworthy details, then add strengths/weaknesses. If the page refreshes, then that means the user cannot check whether he entered the data as the user intended (e.g. free of typo, assigned to a wrong person) because most users will not scroll through more than 10 people just to confirm if they changed the data correctly. Therefore, this is not just a minor inconvenience, nor is it a rare occurrence.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I would disagree that this is just a minor inconvenience. Imagine having a whole soccer team-- that would be 11 + a few more substitute players. In those cases, it would be natural for the user to search for a person using the name or noteworthy details, then add strengths/weaknesses. If the page refreshes, then that means the user cannot check whether he entered the data as the user intended (e.g. free of typo, assigned to a wrong person) because most users will not scroll through more than 10 people just to confirm if they changed the data correctly. Therefore, this is not just a minor inconvenience, nor is it a rare occurrence.