ralfw
commented
8 years ago So we've arrived at a matter of personal preference :-) Because for me the background coloring spanning the whole viewport is looking just fine/preferable. And if it's simpler to draw in a truly consistent manner (without any glitches depending on zooming level or the function lines visible), then why not go for it?
Your example, @robinsedlaczek, is looking bad, because there's so much whitespace to the right of your code. To be honest, I haven't seen anyone arranging VS windows like that before ;-) You seem to have no lack of screen real estate - but most people have. Even in your second example you already zoomed in.
So my guess is: most devs won't see mostly empty colored rectangles because their screens are full of all sorts of IDE panes.
That's why I strongly favor a simpler solution at the moment. It's good enough visually and (as I hear) simplifies the code - which is always a good thing ;-)
robinsedlaczek
Hey David! Many thanks for the PR and great to have you on board! :+1: Kind of Deja Vu regarding the code documentation. :) So we should schedule the suggested user group meeting. :) Please see the line notes.
I really like the refactorings you have made and also the fix for #45. What I do not like in this solution is the width of the method backgrounds. The colored background covers the complete viewport width:
This is too much from my point of view. The IDE gets motley what results in loss of user attention and focus. We should only color those parts that are of interest and only as much as needed. And that's are the method bodies.
Maybe we can find a way to calculated the width of the methods regardless of whether the method is completely visible or not.