Rename config file - Githubissues

ralfw commented 5 years ago

The config file should be renamed to .forcefeedbackprogramming.

This would follow the convention for config files in some other tools.

A file with this name can exist on all levels: project, sln, and global.

Existing config files should be renamed automatically.

ralfw commented 5 years ago

@matt-inteltech Please resolve this issue. Since there are not many users out there please skip renaming old config files.

The focus should be on reading config data from a file named .forcefeedbackprogramming. For now just replace the current config filename with the new one. That's all.

Estimated effort: 30min

robinsedlaczek commented 5 years ago

Hi Ralf, hi Matt,

nice to see you back again, Ralf. And welcome Matt!

Please do not forget to review our contribution guidelines before starting: https://github.com/robinsedlaczek/ForceFeedbackProgramming/wiki

Looking forward,

Robin

Robin Sedlaczek .NET User Group Berlin | Wave Developments | The Berlin Microsoft Connection

Warschauer Straße 60 10243 Berlin, Germany

W http://robinsedlaczek.com/http://robinsedlaczek.wordpress.com/ W http://dotnet-berlinbrandenburg.de/ T https://twitter.com/RobinSedlaczek F https://www.facebook.com/TheBerlinMicrosoftConnection https://www.facebook.com/TheBerlinMicrosoftConnection

From: Ralf Westphal notifications@github.com Sent: Monday, December 17, 2018 22:37 To: robinsedlaczek/ForceFeedbackProgramming Cc: Subscribed Subject: Re: [robinsedlaczek/ForceFeedbackProgramming] Rename config file (#65)

@matt-inteltechhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmatt-inteltech&data=02%7C01%7C%7C9d4c616272a84415590008d66467d29b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636806794400668244&sdata=arJo%2FgplfzfQtbnwpm3QKgJQBJ%2BuK4K8SmMlg6RpDdU%3D&reserved=0 Please resolve this issue. Since there are not many users out there please skip renaming old config files.

The focus should be on reading config data from a file named .forcefeedbackprogramming. For now just replace the current config filename with the new one. That's all.

Estimated effort: 30min

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobinsedlaczek%2FForceFeedbackProgramming%2Fissues%2F65%23issuecomment-448007774&data=02%7C01%7C%7C9d4c616272a84415590008d66467d29b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636806794400668244&sdata=laJELTWDjnUlGEC5WKrg%2BCb70x8D%2Ba5beYdfFUr%2BuL8%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACxBAImtjgw2aB4O89KbU_UDF0O_R0icks5u6A6OgaJpZM4ZVXfz&data=02%7C01%7C%7C9d4c616272a84415590008d66467d29b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636806794400668244&sdata=FuaRy9rXPc%2B0%2FcNIbhOaA13t23NkwzLbw2wr0gDLxl8%3D&reserved=0.

matt-inteltech commented 5 years ago

Nice to meet you, Robin.

I read contribution guidelines. I forked development branch to my repository. I will replace current config filename with .forcefeedbackprogramming.

matt-inteltech commented 5 years ago

Can you let me know exact path of config file that need to be renamed? only one file - ForceFeedback.Rules/Resources/Config.json And refactor code of file name "config.json". is it right?

ralfw commented 5 years ago

You find the path of the config file here: https://github.com/robinsedlaczek/ForceFeedbackProgramming/blob/9c1c0d8175cd57dffd79acb6247ecb5a229f6e0a/ForceFeedback/ForceFeedback.Rules/Configuration/ConfigurationManager.cs#L41

So far there is only a global config file in this path with the name config.json.

For now only this needs to be renamed.

matt-inteltech commented 5 years ago

Thanks for the answer.

How do you debug code?

ralfw commented 5 years ago

What do you mean by "how do you debug code"? You are using VS2017. A debugger is integrated ;-)

matt-inteltech commented 5 years ago

When I click Start button, I see this. What should I do?

ralfw commented 5 years ago

I don't know how to manually test the extension except by installing it and running it and checking what happens. (But I think I remember you can start a second VS instance with the extension running and you can attach a debugger. I thought you were the VS extension expert. You should know ;-) )

That said I have to admit that this codebase is not clean (as you might have realized yourself already). It's more like a prototype than production code. By definition it's legacy code because there are no automated tests.

So what you might want to do first is add a test project and put for example the config manager under test.

matt-inteltech commented 5 years ago

When I create new VS extension project and run, I see "Experimental Instance" in titlebar of second VS window. But FFP doesn't show. I think this is the reason I can't debug.