int should be int32 in GetDTLAt()

robinson / gos7

Implementation of Siemens S7 protocol in golang

BSD 3-Clause "New" or "Revised" License

314 stars 121 forks source link

int should be int32 in GetDTLAt() #21

Closed ThinkontrolSY closed 4 years ago

ThinkontrolSY commented 4 years ago

https://github.com/robinson/gos7/blob/929a8656546f34c7c6196bd31cefefc78ee399e6/helper.go#L177

nsec in S7 is a UDInt, which is 4 word (32bit) length, int size may 32bit or 64bit depend on cpu architecture, may cause problem when running on 64bit cpu

robinson commented 4 years ago

Hi @ThinkontrolSY, highly appreciated for point this out and some other issues as well. Could you please take a pull request thi fix them up if you could. Many thanks for your contributing, Robinson