search

robinson / gos7

Implementation of Siemens S7 protocol in golang
BSD 3-Clause "New" or "Revised" License
314 stars 121 forks source link

There is no judgment of the error. #34

Open j1362212330 opened 4 years ago

j1362212330 commented 4 years ago

func (mb client) send(request ProtocolDataUnit) (response *ProtocolDataUnit, err error) { dataResponse, err := mb.transporter.Send(request.Data)

if err = mb.packager.Verify(request.Data, dataResponse); err != nil {
    return
}
if dataResponse == nil || len(dataResponse) == 0 {
    // Empty response
    err = fmt.Errorf("s7: response data is empty")
    return
}
response = &ProtocolDataUnit{
    Data: dataResponse,
}
//check for error if any
err = responseError(response)
return response, err

}****