search

robinst / autolink-java

Java library to extract links (URLs, email addresses) from plain text; fast, small and smart
MIT License
207 stars 40 forks source link

added support to extract hashtags #13

Closed VijayKumarMidde closed 6 years ago

VijayKumarMidde commented 7 years ago

Hey,

This is a great library! Simple and elegant! We are using this library to extract links, emails, and hashtags from the text. Added support to extract hashtags from the text. Please let me know your comments.

Thanks!

VijayKumarMidde commented 7 years ago

Hey, I made the requested changes. Please let me know your comments :)

VijayKumarMidde commented 7 years ago

Have you had some time to look at the updated pull request?

robinst commented 7 years ago

Yeah, it looks good now, but I wanted to run it against the Twitter test cases before merging, and I didn't get to that yet. If you want to help, writing code to test against them would be awesome!

VijayKumarMidde commented 7 years ago

I think it is a bigger change. I can send that as a new PR after we merge this. What do you think?

simonsilvalauinger commented 6 years ago

is there a chance this will be merged into master?

robinst commented 6 years ago

@simonsilvalauinger I'm waiting for tests that run against Twitter's test cases. I don't want to include something in the library that's going to behave differently. If you want to help out, that would be a nice task to do.