search

robinst / autolink-java

Java library to extract links (URLs, email addresses) from plain text; fast, small and smart
MIT License
207 stars 40 forks source link

Add extractLinksAsTexts and safety update extractLinks. #2

Closed technateNG closed 9 years ago

technateNG commented 9 years ago

I adapted the code to your sugestions. Javadoc preview in eclipse acting differently than the true javadoc in browser. Thanks for your advice.

robinst commented 9 years ago

See inline comments, rest looks good now.

By the way, there is no need to create a new pull request, update the existing one instead. You can either amend your original commit and push it to the same branch, or add a new commit with the changes on top and push.

robinst commented 9 years ago

Hey. Looks like I didn't get a notification about your new commits. Unfortunately, your code doesn't compile anymore (you only renamed the test class, not the file). Could you fix that?

Also, the indentation should use 4 spaces. You used tabs in some places. May I ask which IDE/editor you are using? Maybe I can add a config file that enforces the right style.