Over at https://github.com/lycheeverse/lychee-action/issues/5, we are facing issues with parsing file URLs, specifically inside HTML. Initially I thought the issue was with linkify, so I wrote a quick test to verify my assumption.
Turns out this is not the case and linkify is doing fine. The bug must be elsewhere.
Nevertheless I was wondering if it's a good idea to add a test for file types to make sure that the parsing doesn't break in the future.
I kept the HTML part because I think it's a very common case to have image URLs embedded inside HTML.
Let me know what you think and if I should simplify the test.
robinst
commented
3 years ago
Over at https://github.com/lycheeverse/lychee-action/issues/5, we are facing issues with parsing file URLs, specifically inside HTML. Initially I thought the issue was with linkify, so I wrote a quick test to verify my assumption. Turns out this is not the case and linkify is doing fine. The bug must be elsewhere. Nevertheless I was wondering if it's a good idea to add a test for file types to make sure that the parsing doesn't break in the future. I kept the HTML part because I think it's a very common case to have image URLs embedded inside HTML. Let me know what you think and if I should simplify the test.