Closed cicdguy closed 6 months ago
@robinst, what are your thoughts on this? Is this out of scope for linkify?
Hmm. I wouldn't know how to distinguish this from a plain text case, linkify doesn't even know the file extension.
Does lychee have support for detecting file types via extension? That would help in this case.
Yes, it does. Maybe it could be passed as a parameter to linkify, although I could see why one would not want to do that. Tricky one. Not sure where to draw the line between the tools.
I think in this case it would be nice if lychee could detect csv, use a parser library to parse it and then feed individual cell values to linkify.
That's a great idea and I think that's a solid way forward. Thanks for the insight! I'll update the original issue accordingly.
This is a reference to the issue from https://github.com/lycheeverse/lychee/issues/1299, and it was suggested that I post here for feedback.
Hello,
I'm using lychee 0.13.0, which in turn is using v0.10.0 of linkify (see here) and running it against this file: https://github.com/pharmaverse/admiraldiscovery/blob/06e6e55b884ef91de9ae457606ed66defc9dba14/data-raw/admiral-lookup-book.csv
Like so:
And I get the following result:
When I modify the file by adding quotes around the URLs in the CSV, I get the correct expected result.
Although commas are allowed/safe characters in URLs, will it be possible for linkify to detect CSV files and extract URLs from it without having to wrap the URL strings in quotes?