search

robinst / taglib-ruby

Ruby interface for the TagLib C++ library, for reading and writing meta-data (tags) of many audio formats
https://robinst.github.io/taglib-ruby/
MIT License
256 stars 26 forks source link

Opus support #95

Open meew0 opened 4 years ago

meew0 commented 4 years ago

TagLib supports reading Ogg Opus files: https://taglib.org/api/classTagLib_1_1Ogg_1_1Opus_1_1File.html

However, taglib-ruby only appears to support Ogg Vorbis. Opening opus files with taglib-ruby's vorbis wrapper works in principle, but it does not parse any tags — the tag property will be nil.

Would it be possible to add opus support to taglib-ruby?

robinst commented 4 years ago

I'm sure it would be possible, yeah! It would be nice if someone added, I've marked this issue as help-wanted now.

Sigill commented 4 years ago

FYI, taglib 1.11.1 has a long running issue that cause corruption of Ogg (Vorbis?) files: https://github.com/taglib/taglib/issues/864 Fix is in 1.12-beta, don't know when the final version will be available, though. I havn't tested anything, but since Opus files uses the Ogg container, there's a chance for Opus files to be impacted too.

I'm not sure if support for Opus with the risk of corrupting files is better than no support for Opus. It might be worth waiting for 1.12...

robinst commented 4 years ago

Hmm good to know.